Addressed issues in map_variables_to_terms to support dictionary of isAbout. Fixed up test: test_map_vars_to_terms.py to test for the two supported JSON sidecar formats #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for bids and nidm compliant versions
…ple2_NIDM_examples archive but the current master version doesn't have brain volumes so tests were failing. Changed this code to point to a previous commit of those files while we update the latest to include brain volumes
…es. This is not the case if one is using local paths
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 34.37% 34.35% -0.02%
==========================================
Files 52 52
Lines 6827 6851 +24
Branches 1670 1676 +6
==========================================
+ Hits 2347 2354 +7
- Misses 4313 4328 +15
- Partials 167 169 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@yarikoptic ok, I fixed up the problems from ohbm, fixed up all the pre-commit complaints, fixed up all the test cases. Everything has passed and been merged. I see an auto-release action was run but I see no new release listed. What do I do next? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed up issues with map_variables_to_terms and multiple isAbout concepts
fixed up issues with pytests, dynamic retrieval of github/dbkeator/simple2_NIDM_examples files that don't currently have brain volumes
fixed up lint issues